Pass PHPStan for Laravel 12 #2674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Directives\BaseDirective::$directiveArgs because it might have hooks in a subclass."
spawnia
reviewed
Mar 25, 2025
| @@ -94,11 +94,11 @@ public function testDeleteSubscriber(): void | |||
| $subscriber = new DummySubscriber($channel, 'test-topic'); | |||
| $redisConnection->expects($this->exactly(3)) | |||
| ->method('command') | |||
| ->with(...$this->withConsecutive( | |||
| ->with(...array_values([...$this->withConsecutive( | |||
There was a problem hiding this comment.
Suggested change
| ->with(...array_values([...$this->withConsecutive( | |
| ->with(...array_values($this->withConsecutive( |
spreading once should suffice
There was a problem hiding this comment.
It fails with the following error without "double spreading".
Parameter #1 $array of function array_values expects array, iterable<PHPUnit\Framework\Constraint\Callback> given.
🪪 argument.type
✏️ tests/Unit/Subscriptions/Storage/RedisStorageManagerTest.php:97
Co-authored-by: Benedikt Franke <[email protected]>
|
Thank you, I incorporated parts of your pull request and just released https://github.com/nuwave/lighthouse/releases/tag/v6.54.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes :
PHPDoc tag @return contains generic type PHPUnit\Framework\MockObject\Builder\InvocationMocker but class PHPUnit\Framework\MockObject\Builder\InvocationMocker is not generic.
Method PHPUnit\Framework\MockObject\Builder\InvocationMocker::with() invoked with unpacked array with possibly string key, but it's not allowed because of @no-named-arguments.
Added or updated tests
Documented user facing changes
Updated CHANGELOG.md
Changes
Breaking changes