-
Notifications
You must be signed in to change notification settings - Fork 34.9k
use main branch for treesitter to remove depracted vim.validate api #1579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Still see the error for nvim-tree, but they have a fix waiting for release: nvim-tree/nvim-tree.lua#3120
|
build = ':TSUpdate', | ||
main = 'nvim-treesitter.configs', -- Sets main module to use for opts | ||
-- [[ Configure Treesitter ]] See `:help nvim-treesitter` | ||
opts = { | ||
ensure_installed = { 'bash', 'c', 'diff', 'html', 'lua', 'luadoc', 'markdown', 'markdown_inline', 'query', 'vim', 'vimdoc' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have also been looking into this and I think the main branch, doesn't support those options at the time. Or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right. seeing some unexpected behavior in treesitter now. My helm template files are actually rendering correctly as yaml now -- but setting filetype :set filetype=helm
seems to break the syntax highlight again. :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe main branch isn't ready for prime time shrug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return {
"nvim-treesitter/nvim-treesitter",
build = ":TSUpdate",
branch = "main",
config = function()
require("nvim-treesitter").install({
"c",
"lua",
"vim",
"vimdoc",
"query",
"elixir",
"heex",
"javascript",
"html",
"rust",
"dart",
})
end,
}
This is the closest I got to replicating the old behavior, but the other options are missing tho. Maybe this helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! that certainly got us closer. but definitely different behavior still.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned by clason in your linked issue, the main branch is not a drop-in replacement, therefore the existing config will not work. You will have to rewrite it if you want to get this merged.
Totally valid! I totally glossed over that 😅 Cheers! |
Recently noticed api deprecated warning while checking
:checkhealth
and opened a ticket with treesitter:nvim-treesitter/nvim-treesitter#7916
Upon reading further, I found out that they have deprecated the
master
branch and are usingmain
-- which removed the deprecated api. I'm updating kickstart to reflect their recommended install settings:https://github.com/nvim-treesitter/nvim-treesitter/tree/main?tab=readme-ov-file#installation