go/consensus/api: Deprecate GetSignerNonce #6207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
peternose
commented
May 29, 2025
| @@ -337,6 +337,12 @@ func (nt *nodeTracker) Nodes(nodes []signature.PublicKey) map[core.PeerID]signat | |||
| } | |||
|
|
|||
| func (nt *nodeTracker) trackKeymanagerNodes(ctx context.Context) { | |||
| select { | |||
| case <-nt.consensus.Synced(): | |||
There was a problem hiding this comment.
The consensus needs to be synced so that WatchStatuses method doesn't fail when the status notifier hook is executed on subscription.
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetSignerNoncemethod should be deprecated and eventually removed, as it does not belong in the core consensus backend. Callers should retrieve the nonce via the account query in the staking backend instead. If this approach proves too complex, a helper method can be added to the staking backend to simplify access.