Use OxCaml instead of OCaml #4012
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When relevant, according to my understanding. And I may have missed some
goldfirere
approved these changes
May 16, 2025
There was a problem hiding this comment.
I think I favor keeping the "stock" qualifier. Except maybe if that word is less familiar, change it to "mainstream"? The appearance (or lack) of the x is a bit subtle.
| @@ -308,7 +308,7 @@ about its implementation.) | |||
|
|
|||
| ## Kind annotations on variables | |||
|
|
|||
| Type variables come in two flavors in OCaml: rigid and unifiable. Rigid type | |||
| Type variables come in two flavors in OxCaml: rigid and unifiable. Rigid type | |||
There was a problem hiding this comment.
Well, the statement is true of OCaml just as much as OxCaml. I'm happy for the change here, but I just wanted to point out that this is not new.
| @@ -76,7 +76,7 @@ let r = create forty_two | |||
| ## Limitations | |||
|
|
|||
| All polymorphic parameter require an annotation. Without an annotation | |||
There was a problem hiding this comment.
Suggested change
| All polymorphic parameter require an annotation. Without an annotation | |
| Each polymorphic parameter requires an annotation. Without an annotation, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When relevant, according to my understanding. And I may have missed
some