Document the separability axis #4015
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinichenko-js
force-pushed
the
dkalinichenko/document-separability-etc
branch
from
9654f2a to
7f01ce3
Compare
goldfirere
approved these changes
May 16, 2025
Co-authored-by: Richard Eisenberg <[email protected]>
goldfirere
reviewed
May 16, 2025
| CR reisenberg: TODO | ||
| The separability axis records whether a type can have float value or non-float value elements, where a float OCaml value is a pointer to an allocated block with the `Double_tag`. | ||
| This axis has three possible values, with `non_float < separable < non_separable`. | ||
| if none of its elements are floats, while a type is `separable` if either all or none |
There was a problem hiding this comment.
Missing beginning of sentence?
goldfirere
reviewed
May 16, 2025
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.
Note that:
mod everythingexcludes nullability and separability by design.immediate_or_nullisnon_separablefor technical reasons (it is the kind ofor_null, and with-bounds do not affect separability).