make map ~a:(fun and map (fun consistent
#2706
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmileTrotignon
commented
Apr 25, 2025
| (definition : Definition.t) | ||
| : | ||
| Flambda.specialised_to | ||
| -> ()) |
There was a problem hiding this comment.
This is not great but it is consistent. I would like to box the arguments, so that
fun
arg1 arg2
: return_type
->
body
is allowed.
|
This seems related to #2397 |
EmileTrotignon
force-pushed
the
fun_consistent-label
branch
from
a83a761 to
62f5320
Compare
EmileTrotignon
force-pushed
the
fun_consistent-label
branch
from
62f5320 to
56358ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There used to be two formatting for these two syntaxes.
This makes them consistent. I picked the syntax of
~a:(funbecause it was the nicest one in my opinion.(funwithout label has slightly less indentation.I would like fun exprs to always be formatted like
because
is just not readable: its quite hard to see were the arg ends and where the body starts.
As a comparison, we never ever do
I realize this is probably to large of a diff overall, but achieving it would also be both nice and make the code a lot simpler.