Skip to content

Add missing parentheses in type expr (_ as 'a) t #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

Julow
Copy link
Collaborator

@Julow Julow commented Jul 1, 2025

This bug is found for example in Eio: https://ocaml.org/p/eio/latest/doc/Eio/Domain_manager/index.html#type-t
Type t renders as invalid syntax:

type 'a t = [> ty ] as 'a Resource.t

In the source code, it's:

type 'a t = ([> ty] as 'a) Resource.t

@jonludlam
Copy link
Member

Looks good, thanks @Julow

The test failure is due to the mpopcnt bug on ARM - a consequence of needing base which I think is only used for Sherlodoc's test suite. It'd be good to fix this but for now I'm just going to ignore the failure.

@jonludlam jonludlam merged commit c121f6c into ocaml:master Jul 2, 2025
10 of 12 checks passed
@jonludlam
Copy link
Member

Oops, forgot the CHANGES entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants