Document core:slice package #5126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Map_Entry :: struct($Key, $Value: typeid) { | ||
| key: Key, | ||
| value: Value, | ||
| } | ||
|
|
||
| /* | ||
| Similar to `Map_Entry` but also includes the hash of the key. |
There was a problem hiding this comment.
Should probably just document this struct fully here; don't make the user go looking somewhere else to find a full definition?
So, something like A map entry, including a key, a value, and the hash of the key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to follow #5039 as close as possible.
If this is merged #2358 should be updated.
In addition to adding and updating doc comments the following changes are made: