refactor: systemd timeout handling and unit status events #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanZachmann
force-pushed
the
refactor-systemd
branch
from
0cf8f78 to
4e9c976
Compare
JanZachmann
changed the title
JanZachmann
changed the title
JanZachmann
force-pushed
the
refactor-systemd
branch
from
4e9c976 to
f88aa66
Compare
Signed-off-by: Jan Zachmann <[email protected]>
JanZachmann
force-pushed
the
refactor-systemd
branch
from
f88aa66 to
28c2bd0
Compare
mlilien
approved these changes
May 20, 2025
empwilli
requested changes
May 23, 2025
| systemd::wait_for_system_running(timeout).await?; | ||
| systemd::wait_for_system_running() | ||
| .await | ||
| .context("validate: wait_for_system_running timed out")?; |
There was a problem hiding this comment.
An error in wait_for_systme_running not necessarily was caused by a timeout? This PR even removes any timeout checks in wait_for_system_running altogether so I'm not 100% sure whether we would error out on any timeouts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.