Only test #2092
Open
Only test #2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yao, Qing <[email protected]>
Signed-off-by: Yao, Qing <[email protected]>
Signed-off-by: Yao, Qing <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: ZePan110 <[email protected]>
…Examples into one_click_dev
Signed-off-by: Yi Yao <[email protected]>
…Examples into one_click_dev
Signed-off-by: ZePan110 <[email protected]>
for more information, see https://pre-commit.ci
…Examples into one_click_dev
Signed-off-by: Yi Yao <[email protected]>
…Examples into one_click_dev
Signed-off-by: Yi Yao <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Yi Yao <[email protected]>
…Examples into one_click_dev
Signed-off-by: Yao, Qing <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
ZePan110
requested review from
letonghan,
lvliang-intel,
ashahba and
lkk12014402
as code owners
ZePan110
requested review from
minmin-intel,
XinyuYe-Intel,
chensuyue,
ftian1 and
rbrugaro
as code owners
Dependency ReviewThe following issues were found:
License Issuesone_click_deploy/requirements.txt
Scanned Files
|
ZePan110
removed request for
ashahba,
ftian1,
lkk12014402,
chensuyue,
minmin-intel,
rbrugaro,
XinyuYe-Intel,
lvliang-intel and
letonghan
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive one‐click deployment suite for GenAI Examples with interactive Python scripts, utility modules, updated configuration files, and supporting shell scripts and CI workflows.
- Added main deployment script (one_click_deploy.py) and extended associated modules (utils.py, deployer.py, tester.py).
- Updated configuration and utility files (config.py, common scripts) and enhanced CI workflows for PR testing and code scanning.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| one_click_deploy/requirements.txt | Added new dependencies for the deployment and testing scripts |
| one_click_deploy/one_click_deploy.py | Introduced the interactive one-click deployment command-line interface |
| one_click_deploy/core/utils.py | Added and refined utility functions for logging, command execution, etc. |
| one_click_deploy/core/tester.py | Implemented connection tester classes and methods |
| one_click_deploy/core/deployer.py | Implemented deployment, service configuration, and cleanup flows |
| one_click_deploy/core/config.py | Extended configuration for multiple GenAI examples |
| one_click_deploy/common/*.sh | Added several shell scripts for utilities, environment checks, and builds |
| .github/workflows/*.yml | Introduced and updated CI workflows for PR tests and code scans |
| Other docker_compose and README files | Updated sample scripts and documentation for deployments |
Comments suppressed due to low confidence (1)
one_click_deploy/one_click_deploy.py:1
- [nitpick] Ensure consistent copyright years across the project; several files use 2025 while others use 2024.
# Copyright (C) 2025 Intel Corporation
| # self.session.proxies = {"http": self.args.http_proxy, "https": self.args.https_proxy} | ||
| self.results = {"passed": 0, "failed": 0, "skipped": 0} | ||
|
|
||
| self.session = requests.Session() |
There was a problem hiding this comment.
The requests.Session() is initialized twice in the init method. Remove the duplicate initialization to improve maintainability.
Suggested change
| self.session = requests.Session() |
Copilot uses AI. Check for mistakes.
ZePan110
force-pushed
the
test-nightly
branch
6 times, most recently
from
287ce85 to
7d07d78
Compare
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
…xamples into test-nightly Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.