chore(gcp-resource-detector): unit test to prevent a regression and ensure previously set attributes are not overwritten with blank values. #2755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/easycla |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2755 +/- ##
==========================================
- Coverage 91.53% 91.31% -0.23%
==========================================
Files 171 166 -5
Lines 8172 7861 -311
Branches 1660 1619 -41
==========================================
- Hits 7480 7178 -302
+ Misses 692 683 -9 🚀 New features to boost your workflow:
|
ajbenjam
force-pushed
the
gcp-resource-detector-unit-test
branch
from
22b3ad3 to
ae16321
Compare
david-luna
approved these changes
Apr 22, 2025
ajbenjam
force-pushed
the
gcp-resource-detector-unit-test
branch
from
ae16321 to
64b3255
Compare
blumamir
approved these changes
May 7, 2025
pichlermarc
reviewed
May 15, 2025
There was a problem hiding this comment.
Looks like this PR is approved but tests are failing as the merge from main included the update from @opentelemetry/[email protected] to @opentelemetry/[email protected] - please update the tests, then we can get this merged (see comment below) 🙂
detectors/node/opentelemetry-resource-detector-gcp/test/detectors/GcpDetector.test.ts
Outdated
Show resolved
Hide resolved
…nsure previously set attributes are not overwritten with blank values. When attributes have already been set by other detectors, such as the EnvDetector, when the GcpDetector is run, it should not overwrite an existing attribute with a blank value if the source environment variable doesn't exist. Prior to commit 143a1f4, the behavior was as follows: - OTEL_RESOURCE_ATTRIBUTES = 'k8s.namespace.name=my-namespace' - NAMESPACE is undefined - EnvDetector runs and adds 'k8s.namespace.name=my-namespace' to attributes list - GcpDetector runs and sets 'k8s.namespace.name=' (blank) The GcpDetector should only set 'k8s.namespace.name' if the source environment variable is defined.
ajbenjam
force-pushed
the
gcp-resource-detector-unit-test
branch
from
0763b98 to
d5a0bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
The GcpDetector should only set 'k8s.namespace.name' if the source environment variable is defined.