chore: upgrade lerna #2836
chore: upgrade lerna #2836
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2836 +/- ##
==========================================
+ Coverage 89.63% 89.68% +0.04%
==========================================
Files 184 184
Lines 9003 9003
Branches 1845 1845
==========================================
+ Hits 8070 8074 +4
+ Misses 933 929 -4 🚀 New features to boost your workflow:
|
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
| popd | ||
| done | ||
| ```sh | ||
| npx lerna publish from-package --no-push --no-private --no-git-tag-version --no-verify-access --yes |
There was a problem hiding this comment.
I think the whole RELEASING.md can be removed, or we can refer to the release-please workflow that basically handles all the releases now. 🙂
(In the 2.5 years I've been a maintainer, I've never needed to do a manual release in the contrib repo 🙂)
| "watch": "tsc --build --watch tsconfig.json tsconfig.esm.json tsconfig.esnext.json", | ||
| "precompile": "lerna run version --scope @opentelemetry/propagator-aws-xray --include-dependencies", | ||
| "prewatch": "npm run precompile" | ||
| "watch": "tsc --build --watch tsconfig.json tsconfig.esm.json tsconfig.esnext.json" |
There was a problem hiding this comment.
Q: I am ignorant here. Does removing this precompile mean that I see the npm run compile at the top-level before working on this package? (Maybe that is already a requirement.)
CONTRIBUTING.md
Outdated
| @@ -119,6 +119,29 @@ Some tests depend on other packages to be installed, so these steps are also req | |||
|
|
|||
| Each of these commands can also be run in individual packages, as long as the initial install and compile are done first in the root directory. | |||
|
|
|||
| If you're going to work on a single package and want to quickly jump into its development you can make use of the `focus` script. This scritp will run | |||
There was a problem hiding this comment.
nit:
| If you're going to work on a single package and want to quickly jump into its development you can make use of the `focus` script. This scritp will run | |
| If you're going to work on a single package and want to quickly jump into its development you can make use of the `focus` script. This script will run |
| @@ -119,6 +119,29 @@ Some tests depend on other packages to be installed, so these steps are also req | |||
|
|
|||
| Each of these commands can also be run in individual packages, as long as the initial install and compile are done first in the root directory. | |||
|
|
|||
There was a problem hiding this comment.
I think it woudl be helpful to have a separate section header for this new focus thing.
| popd | ||
| done | ||
| ```sh | ||
| npx lerna publish from-package --no-push --no-private --no-git-tag-version --no-verify-access --yes |
There was a problem hiding this comment.
From the top of this file:
For posterity, or in the event of any failures with release-please, the process for performing a manual release is below.
Given this gets out of date, it would possibly be better to drop it. I'd defer to @pichlermarc for an opinion on that as he does most of the releasing.
Update: Marc already gave an opinion on this above (#2836 (comment)).
| > NX Successfully ran target compile for project @opentelemetry/resource-detector-aws and 3 tasks it depends on (7s) | ||
| ``` | ||
|
|
||
| Once the command is done you can `cd` into the package and start using the usual commands. |
There was a problem hiding this comment.
(non-blocking) I'm not opposed to this command, but it would be kind of nice to not have to type out both (a) the package name and (b) the directory for that package.
Possible alternative:
cd detectors/node/opentelemetry-resource-detector-aws # or whatever package to focus on
npm run compile:include-deps
Or perhaps others would find a command at the top-level more convenient? My personal typical development process is that I cd into the package dir I am working on and work from there. So an npm run ... script in that package dir would be convenient for me.
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
Which problem is this PR solving?
This is a follow up PR of #2493. It updates
lernato version v8.2.2, which indirectly updatesnx. Dev scripts are usingnxdirectly but publish workflows and tasks keep usinglernaChanges
lernadependencyscripts/peer-api-check.mjsto work at the root level and the dependant workflowsscripts/check-release-please.mjs, simplificationfocusnpm script for people who does not want to compile all project to start developingSupersedes: #2526