Bump semantic-conventions to 1.36.0 #4669
Open
+1,284
−238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emdneto <[email protected]>
emdneto
commented
Jul 8, 2025
opentelemetry-semantic-conventions/src/opentelemetry/semconv/attributes/db_attributes.py
Show resolved
Hide resolved
xrmx
reviewed
Jul 8, 2025
...y-semantic-conventions/src/opentelemetry/semconv/_incubating/attributes/gen_ai_attributes.py
Show resolved
Hide resolved
xrmx
reviewed
Jul 8, 2025
| @@ -88,7 +88,7 @@ def create_{{ metric_name }}(meter: Meter) -> {{metric.instrument | map_text("py | |||
| {%- if metric.instrument == "gauge" %} | |||
| callbacks=callbacks, | |||
| {%- endif %} | |||
| description="{{ c.str_or_empty(metric.brief|trim) }}", | |||
| description="{{ c.str_or_empty(metric.brief|trim)|replace('\n', ' ')|replace('\r', ' ') }}", | |||
There was a problem hiding this comment.
Suggested change
| description="{{ c.str_or_empty(metric.brief|trim)|replace('\n', ' ')|replace('\r', ' ') }}", | |
| description="""{{ c.str_or_empty(metric.brief|trim)""", |
Would a multiline comment work?
There was a problem hiding this comment.
Let me try.
Yup. This worked: description="""{{ c.str_or_empty(metric.brief|trim) }}""",
It generates:
def create_k8s_resourcequota_cpu_request_used(meter: Meter) -> UpDownCounter:
"""The CPU requests in a specific namespace.
The value represents the current observed total usage of the resource in the namespace"""
return meter.create_up_down_counter(
name=K8S_RESOURCEQUOTA_CPU_REQUEST_USED,
description="""The CPU requests in a specific namespace.
The value represents the current observed total usage of the resource in the namespace.""",
unit="{cpu}",
)There was a problem hiding this comment.
This will also change for all metrics we already have @xrmx . are you okay with that?
|
For the lint error I guess we can add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skipping 1.35.0 due to issues open-telemetry/semantic-conventions#2455