Skip to content

Bump semantic-conventions to 1.36.0 #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Jul 8, 2025

Description

Skipping 1.35.0 due to issues open-telemetry/semantic-conventions#2455

@emdneto emdneto requested a review from a team as a code owner July 8, 2025 01:41
@@ -88,7 +88,7 @@ def create_{{ metric_name }}(meter: Meter) -> {{metric.instrument | map_text("py
{%- if metric.instrument == "gauge" %}
callbacks=callbacks,
{%- endif %}
description="{{ c.str_or_empty(metric.brief|trim) }}",
description="{{ c.str_or_empty(metric.brief|trim)|replace('\n', ' ')|replace('\r', ' ') }}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description="{{ c.str_or_empty(metric.brief|trim)|replace('\n', ' ')|replace('\r', ' ') }}",
description="""{{ c.str_or_empty(metric.brief|trim)""",

Would a multiline comment work?

Copy link
Member Author

@emdneto emdneto Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try.
Yup. This worked: description="""{{ c.str_or_empty(metric.brief|trim) }}""",

It generates:

def create_k8s_resourcequota_cpu_request_used(meter: Meter) -> UpDownCounter:
    """The CPU requests in a specific namespace.
    The value represents the current observed total usage of the resource in the namespace"""
    return meter.create_up_down_counter(
        name=K8S_RESOURCEQUOTA_CPU_REQUEST_USED,
        description="""The CPU requests in a specific namespace.
The value represents the current observed total usage of the resource in the namespace.""",
        unit="{cpu}",
    )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also change for all metrics we already have @xrmx . are you okay with that?

@xrmx
Copy link
Contributor

xrmx commented Jul 8, 2025

For the lint error I guess we can add the #pylint: disable=too-many-lines to the templates by default 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants