-
Notifications
You must be signed in to change notification settings - Fork 716
Bump semantic-conventions to 1.36.0 #4669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: emdneto <[email protected]>
opentelemetry-semantic-conventions/src/opentelemetry/semconv/attributes/db_attributes.py
Show resolved
Hide resolved
...y-semantic-conventions/src/opentelemetry/semconv/_incubating/attributes/gen_ai_attributes.py
Show resolved
Hide resolved
@@ -88,7 +88,7 @@ def create_{{ metric_name }}(meter: Meter) -> {{metric.instrument | map_text("py | |||
{%- if metric.instrument == "gauge" %} | |||
callbacks=callbacks, | |||
{%- endif %} | |||
description="{{ c.str_or_empty(metric.brief|trim) }}", | |||
description="{{ c.str_or_empty(metric.brief|trim)|replace('\n', ' ')|replace('\r', ' ') }}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description="{{ c.str_or_empty(metric.brief|trim)|replace('\n', ' ')|replace('\r', ' ') }}", | |
description="""{{ c.str_or_empty(metric.brief|trim)""", |
Would a multiline comment work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try.
Yup. This worked: description="""{{ c.str_or_empty(metric.brief|trim) }}""",
It generates:
def create_k8s_resourcequota_cpu_request_used(meter: Meter) -> UpDownCounter:
"""The CPU requests in a specific namespace.
The value represents the current observed total usage of the resource in the namespace"""
return meter.create_up_down_counter(
name=K8S_RESOURCEQUOTA_CPU_REQUEST_USED,
description="""The CPU requests in a specific namespace.
The value represents the current observed total usage of the resource in the namespace.""",
unit="{cpu}",
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also change for all metrics we already have @xrmx . are you okay with that?
For the lint error I guess we can add the |
Description
Skipping 1.35.0 due to issues open-telemetry/semantic-conventions#2455