Skip to content

Remove unused variables 'text_features' and 'image_features' #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

developer0hye
Copy link

@developer0hye developer0hye commented Jun 13, 2023

The text_features and image_features was calculated but not used in the code.

@developer0hye developer0hye changed the title Remove unused variable 'text_features' Remove unused variables 'text_features' and 'image_features' Jun 13, 2023
@jongwook
Copy link
Collaborator

jongwook commented Jul 8, 2023

The lines are intended to show how to calculate the text and image features separately, as opposed to getting the logits which need both text and image inputs.

@jongwook jongwook closed this Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants