Migrate the plugin envelope for Elastic 8 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update the Elasticsearch version to v8.18.1 * add the spotless Gradle plugin to format the code. Also added two config files to spotless from the Elastic github repo * formatterConfig.xml * elastic.importerorder * fix some missing dependencies such as jts-core and spatial4j
and carry out some formatting thanks to the spotless Gradle plugin * the 'AggregationSpec' constructor is not the same. Get rid of a deprecation warning * implement the 'getMinimalSupportedVersion' method * remove the 'getRegistryKey' method * update the 'getLeafCollector' method * replace the 'reduce' method to 'getLeaderReducer'
As the legacy-geo is not more distributed with Elastic, we: 1. compiled this module from the Elastic v8.18.1 source code with './gradlew :modules:legacy-geo:assemble' 2. copy/pasted it into this repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this plugin compatible with Elastic v8.18.1
Discussions
Not sure about the minimal transport version (which is not the same as the Elasticsearch version). For now, I just set
TransportVersions.MINIMUM_COMPATIBLE(which isV_7_17_0).Maybe it's worth to remove legacy-geo and replace it by elasticsearch-geo
Summary
update the gradle.build
two config files to spotless from the Elastic github repo
update gradlew
make the code compatible with the Elastic 8 API
and carry out some formatting thanks to the spotless Gradle plugin
update the Dockerfile
add the legacy-geo-8.18.1.jar
As the legacy-geo is not more distributed with Elastic, we:
with './gradlew :modules:legacy-geo:assemble'
update the README file