Skip to content

8357173: Split jtreg test group jdk tier3 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented May 27, 2025

Clean backport of this change.

We need to be able to run the jdk_jpackage tests separately from the rest of jdk tier3 due to different requirements on the test environment. To achieve this we would like to introduce tier3_part1 and tier3_jpackage groups as sub groups to tier3.


Progress

  • JDK-8357173 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357173: Split jtreg test group jdk tier3 (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/226/head:pull/226
$ git checkout pull/226

Update a local copy of the PR:
$ git checkout pull/226
$ git pull https://git.openjdk.org/jdk24u.git pull/226/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 226

View PR using the GUI difftool:
$ git pr show -t 226

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/226.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2025

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport afcbf6b2f49c00a544e6db5b4ed9da76c0bdcba4 8357173: Split jtreg test group jdk tier3 May 27, 2025
@openjdk
Copy link

openjdk bot commented May 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 27, 2025

⚠️ @erikj79 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 27, 2025
@mlbridge
Copy link

mlbridge bot commented May 27, 2025

Webrevs

@erikj79
Copy link
Member Author

erikj79 commented May 27, 2025

/approval request This change is required for continued testing of jpackage tests in Oracle's internal test system.

@openjdk
Copy link

openjdk bot commented May 27, 2025

@erikj79
8357173: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels May 27, 2025
@erikj79 erikj79 marked this pull request as draft May 28, 2025 19:48
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant