Rework Menu #15
Merged
Rework Menu #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
waaaaargh
commented
May 16, 2025
waaaaargh
commented
- Add Header text again (right for small devices, left otherwise)
- Add Site for tools
- Make Hamburger Menu and navbar the same
There was a problem hiding this comment.
Pull Request Overview
This PR reworks the menu by revisiting the header text and navigation layout to provide a consistent look for both mobile and desktop devices while introducing a dedicated tools page.
- Added a new tools page ("src/pages/tools.astro") with tool cards.
- Updated the Layout ("src/layouts/Layout.astro") to align the hamburger menu and navbar, including adjustments for header text display on different devices.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/pages/tools.astro | Introduces a dedicated tools page with tool cards and links. |
| src/layouts/Layout.astro | Updates the navigation layout and header text for mobile/desktop. |
| <div class="dropdown dropdown-start"> | ||
| <div tabindex="0" role="button" class="btn btn-ghost lg:hidden"> | ||
| <div class="hidden px-5 md:inline"> | ||
| <strong>OpenLab Augsburg e.V.</strong> |
There was a problem hiding this comment.
Consider using consistent branding text between mobile and desktop views (e.g., 'OpenLab Augsburg e.V.' vs 'OpenLab Augsburg') to enhance user experience.
Suggested change
| <strong>OpenLab Augsburg e.V.</strong> | |
| <strong>{BASE_TITLE} e.V.</strong> |
Copilot uses AI. Check for mistakes.
waaaaargh
force-pushed
the
chore/rework-menu
branch
from
59beb42 to
9ebb934
Compare
Y0ngg4n
approved these changes
May 17, 2025
|
im merging this now. sorry not sorry 💅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.