Skip to content

Conditionally Require Fields in MDS Stops Endpoint Related to Station Based Program/SLA Metrics #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025

Conversation

mschwartzie
Copy link
Contributor

Added conditionally required fields and language


name: Default
about: Suggest changes to MDS
title:


MDS Pull Request

Thank you for your contribution! Please review our OMF contributing page to understand guidelines and policies for participation, and our Code of Conduct page.

To avoid complications and help make the Review process as smooth as possible, make sure to:

  1. Target dev branch. Please ensure you are targeting dev, not main.
  2. Keep the "Allow edits from maintainers" button checked to help us resolve some issues for you.
  3. Be ready to resolve any merge conflicts before we approve your Pull Request.
  4. Have an up to date profile, per our Github community profile guildance.

Explain pull request

Some fields need to be conditionally required in MDS Stops so that metric calculations can be done to ensure compliance with station based SLAs. More info at #929

Is this a breaking change

  • No, not breaking

Impacted Spec

Which spec(s) will this pull request impact?

  • agency
  • provider

Additional context

Add any other context or screenshots about the feature request here.

Added conditionally required fields and language

Signed-off-by: Michael Schwartz <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Apr 29, 2025

CLA assistant check
All committers have signed the CLA.

@mschwartzie mschwartzie marked this pull request as ready for review April 29, 2025 20:48
@mschwartzie mschwartzie requested a review from a team as a code owner April 29, 2025 20:48
@mschwartzie mschwartzie changed the title Update data-types.md Conditionally Require Fields in MDS Stops Endpoint Related to Station Based Program/SLA Metrics Apr 30, 2025
@schnuerle schnuerle added the minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update. label Apr 30, 2025
@schnuerle schnuerle linked an issue Apr 30, 2025 that may be closed by this pull request
@schnuerle schnuerle added this to the 2.0.2 milestone Apr 30, 2025
Clarified conditions in which the field would be required

Signed-off-by: Michael Schwartz <[email protected]>
@schnuerle schnuerle merged commit f5c8dd4 into openmobilityfoundation:dev Jun 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditionally require fields for MDS Stops
3 participants