Add an asset resolver override

[vicb]

fixes #707

We plan to use that for the Cloudflare adapter when the worker runs in front of the assets (see )

The current override looks like:

const resolver: AssetResolver = {
	name: "cloudflare-worker-first",
	async maybeGetAssetResult(event: InternalEvent) {
		const { ASSETS } = getCloudflareContext().env;
		if (!ASSETS) {
			return undefined;
		}
		const { method, headers } = event;
		if (method !== "GET" && method != "HEAD") {
			return undefined;
		}

		const response = await ASSETS.fetch(new URL(event.rawPath, "https://assets.local"), {
			headers,
			method,
		});

		if (response.status === 404) {
			return undefined;
		}

		const body = response.body || new ReadableStream();

		return {
			type: "core",
			statusCode: response.status,
			headers: Object.fromEntries(response.headers.entries()),
			// Workers and Node types differ.
			// eslint-disable-next-line @typescript-eslint/no-explicit-any
			body: body as any,
			isBase64Encoded: false,
		} satisfies InternalResult;
	},
};

Note I think beforeFiles and afterFiles behavior do not match the Next doc - they all should be applied (vs only the first match in ON).

[changeset-bot]

🦋 Changeset detected

Latest commit: 1dfa027

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@opennextjs/aws	Minor
app-pages-router	Patch
app-router	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@917

commit: 1dfa027

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	26.97%	2639 / 9784
🔵	Statements	26.97%	2639 / 9784
🔵	Functions	54.26%	140 / 258
🔵	Branches	73.23%	621 / 848

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/open-next/src/adapters/middleware.ts	0%	0%	0%	0%	1-129
packages/open-next/src/core/createMainHandler.ts	0%	0%	0%	0%	1-67
packages/open-next/src/core/requestHandler.ts	0%	0%	0%	0%	1-347
packages/open-next/src/core/resolve.ts	0%	100%	100%	0%	14-170
packages/open-next/src/core/routingHandler.ts	0%	0%	0%	0%	1-294
packages/open-next/src/core/routing/matcher.ts	73.55%	73.46%	92.3%	73.55%	39-41, 50-54, 59-61, 64, 103, 105, 108, 111, 121-122, 164-166, 237-244, 315-317, 319-332, 351-352, 424-486
packages/open-next/src/overrides/assetResolver/dummy.ts	0%	100%	100%	0%	8-12
packages/open-next/src/types/global.ts	0%	0%	0%	0%
packages/open-next/src/types/open-next.ts	0%	0%	0%	0%
packages/open-next/src/types/overrides.ts	0%	0%	0%	0%

Generated in workflow #1346 for commit 1dfa027 by the Vitest Coverage Report Action

[conico974]

I think we don't have a choice, but to check every single static assets in maybeGetAssetResult

[conico974]

Is it for all or only for beforeFiles ? The docs talks about beforeFiles only for that.
We need to look at how this is done in Next, but yeah definitely needs to be fixed

[vicb]

It is a few lines appart but

Good to know: rewrites in beforeFiles do not check the filesystem/dynamic routes immediately after matching a source, they continue until all beforeFiles have been checked.

and

afterFiles rewrites are checked/applied, if one of these rewrites is matched we check dynamic routes/static files after each match

[vicb]

Thanks for the review

I'll check the implementation and update the PR

[vicb]

It is a few lines appart but

Good to know: rewrites in beforeFiles do not check the filesystem/dynamic routes immediately after matching a source, they continue until all beforeFiles have been checked.

and

afterFiles rewrites are checked/applied, if one of these rewrites is matched we check dynamic routes/static files after each match

[vicb]

@conico974 I think I have addressed all the feedback, could you please take another look?

[conico974]

LGTM Thanks!

[vicb]

Thanks for the review and feedback Nico!