fix(metrics): Fix flaky test [TET-505] (getsentry#40954)

Author: Riccardo Busetti

src/sentry/snuba/metrics/query.py

@@ -264,6 +264,9 @@ def calculate_intervals_len(
             end = datetime.fromtimestamp(int(end.timestamp() / interval) * interval, timezone.utc)
 
             range_in_sec = (end - start).total_seconds()
+            if range_in_sec == 0:
+                raise InvalidParams("Rounded start and end time are the same")
+
             denominator = interval
         return math.ceil(range_in_sec / denominator)
 

tests/sentry/snuba/metrics/test_query.py

@@ -3,6 +3,7 @@
 from typing import Optional, Sequence
 
 import pytest
+from freezegun import freeze_time
 from snuba_sdk import Direction, Granularity, Limit, Offset
 from snuba_sdk.conditions import ConditionGroup
 
@@ -616,7 +617,7 @@ def test_ensure_interval_set_to_granularity_in_performance_queries():
     assert mq.interval == mq.granularity.granularity
 
 
-@pytest.mark.skip(reason="flaky test: TET-505")
+@freeze_time("2022-11-03 10:10:00")
 @pytest.mark.parametrize(
     "granularity, interval, expected_granularity",
     [
@@ -645,3 +646,18 @@ def test_ensure_granularity_is_less_than_interval(granularity, interval, expecte
     metrics_query_dict = metrics_query.to_metrics_query_dict()
     mq = MetricsQuery(**metrics_query_dict)
     assert mq.granularity.granularity == expected_granularity
+
+
+@freeze_time("2022-11-03 09:45:00")
+def test_ensure_intervals_len_0_results_in_error():
+    metrics_query = (
+        MetricsQueryBuilder()
+        .with_select([MetricField(op="p95", metric_mri=TransactionMRI.DURATION.value)])
+        .with_include_series(True)
+        .with_granularity(Granularity(86400))
+        .with_interval(7200)
+    )
+
+    with pytest.raises(InvalidParams):
+        metrics_query_dict = metrics_query.to_metrics_query_dict()
+        MetricsQuery(**metrics_query_dict)