Skip to content

fix(metrics): Fix flaky test [TET-505] #40954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2022
Merged

fix(metrics): Fix flaky test [TET-505] #40954

merged 2 commits into from
Nov 4, 2022

Conversation

iambriccardo
Copy link
Contributor

@iambriccardo iambriccardo commented Nov 3, 2022 •
edited
Loading

This PR aims at fixing the flakiness introduced by the test

sentry/tests/sentry/snuba/metrics/test_query.py

Line 637 in 721f227

def test_ensure_granularity_is_less_than_interval(granularity, interval, expected_granularity):
.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 3, 2022
@iambriccardo iambriccardo changed the title fix(metrics): Fix flaky test fix(metrics): Fix flaky test [TET-505] Nov 3, 2022
@iambriccardo iambriccardo marked this pull request as ready for review November 3, 2022 11:46
@iambriccardo iambriccardo requested a review from a team as a code owner November 3, 2022 11:46
@iambriccardo iambriccardo merged commit 045a355 into master Nov 4, 2022
@iambriccardo iambriccardo deleted the riccardo/TET-505 branch November 4, 2022 07:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@priscilawebdev priscilawebdev priscilawebdev approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iambriccardo @priscilawebdev