perf: avoid unnecessary getThis in writeToOutputBuffer #3548
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dudantas
changed the title
dudantas
approved these changes
May 23, 2025
dudantas
changed the title
feliphechaves
pushed a commit
to feliphechaves/opentibiabr
that referenced
this pull request
May 27, 2025
) This PR optimizes the ProtocolGame::writeToOutputBuffer method by avoiding the unnecessary creation of shared_from_this() (getThis()) when already within the dispatcher context. Previously, the method always called getThis() to capture self, even when already executing inside the dispatcher, which introduced significant overhead due to shared_ptr management. Now, the check g_dispatcher().context().isAsync() ensures that if we're already in the dispatcher context, the operation is performed immediately and directly, avoiding the cost of shared_from_this(). This change eliminates the need to create extra shared_ptr instances in common scenarios, reducing pressure on the reference counting system and improving overall performance, especially under high load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the ProtocolGame::writeToOutputBuffer method by avoiding the unnecessary creation of shared_from_this() (getThis()) when already within the dispatcher context.
Previously, the method always called getThis() to capture self, even when already executing inside the dispatcher, which introduced significant overhead due to shared_ptr management. Now, the check g_dispatcher().context().isAsync() ensures that if we're already in the dispatcher context, the operation is performed immediately and directly, avoiding the cost of shared_from_this().
This change eliminates the need to create extra shared_ptr instances in common scenarios, reducing pressure on the reference counting system and improving overall performance, especially under high load.