Fix data race in BLE GATT implementation #1020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the wait condition before actually writing the value in the characteristic, as the callback that reads the value might be called before the value is actually set. Test: ./gradlew multipaz:check multipaz:connectedCheck Test: Manually tested local build with our wallet implementation Signed-off-by: Henry Jalonen <[email protected]>
Signed-off-by: Henry Jalonen <[email protected]>
davidz25
reviewed
Jun 3, 2025
| @@ -56,7 +56,7 @@ class JsonWebEncryptionTests { | |||
| Curve.P_256, | |||
| recipientKey.publicKey.javaPublicKey as ECPublicKey, | |||
| recipientKey.javaPrivateKey as ECPrivateKey, | |||
| null, null, null, null, null, null, null, null, null | |||
| null, null, null, null, null, null, null, null, null, null, null, null | |||
There was a problem hiding this comment.
Why is this change needed?
| @@ -120,7 +116,7 @@ class JsonWebSignatureTests { | |||
| Curve.P_256, | |||
| signingKey.publicKey.javaPublicKey as ECPublicKey, | |||
| signingKey.javaPrivateKey as ECPrivateKey, | |||
| null, null, null, null, null, null, null, null, null | |||
| null, null, null, null, null, null, null, null, null, null, null, null | |||
|
Ah, OK, I now realize you had two commits so I'll just merge both. In the future please use separate PRs for separate fixes, it's easier to review that way - thanks! |
davidz25
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the wait condition before actually writing the value in the characteristic, as the callback that reads the value might be called before the value is actually set.
Test: ./gradlew multipaz:check multipaz:connectedCheck
Test: Manually tested local build with our wallet implementation
Fixes #1019