Skip to content

deduplication patches #6340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

deduplication patches #6340

merged 3 commits into from
Apr 30, 2025

Conversation

ajtmccarty
Copy link
Contributor

@ajtmccarty ajtmccarty commented Apr 21, 2025

IFC-1432
must follow #6311

adds two patches for the new infrahub db patch commands

  1. consolidate duplicated nodes - finds pairs of identical Node nodes (like the kind that would be created following a merge of a branch that updated a node's kind or inheritance) and moves all of the edges on all of the duplicative nodes to one of the duplicated nodes before deleting the others
  2. delete duplicated edges - for a given pair of linked nodes, finds duplicated or overlapping edges of the same status, type, and branch. for each group of edges, it sets the from time to the earliest of the edges in this group (and optionally the to time if it is an active edge has been deleted) and then deletes all of the duplicates

@ajtmccarty ajtmccarty force-pushed the ajtm-04212025-dedup-patches branch from b6bc27a to d031e82 Compare April 21, 2025 22:16
@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Apr 21, 2025
Copy link

codspeed-hq bot commented Apr 21, 2025

CodSpeed Performance Report

Merging #6340 will not alter performance

Comparing ajtm-04212025-dedup-patches (5521508) with stable (048608f)

Summary

✅ 10 untouched benchmarks

@ajtmccarty ajtmccarty force-pushed the ajtm-04212025-dedup-patches branch from d031e82 to e5595c2 Compare April 23, 2025 20:43
@ajtmccarty ajtmccarty marked this pull request as ready for review April 23, 2025 22:04
@ajtmccarty ajtmccarty requested a review from a team as a code owner April 23, 2025 22:04
Base automatically changed from ajtm-04152025-duplication-patch to stable April 24, 2025 14:24
@ajtmccarty ajtmccarty requested review from a team as code owners April 24, 2025 14:24
@ajtmccarty ajtmccarty force-pushed the ajtm-04212025-dedup-patches branch from e5595c2 to c40a07e Compare April 24, 2025 20:10
Copy link
Contributor

@ogenstad ogenstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests to show it in action and that would also prevent future regressions if things are changed?

@ajtmccarty ajtmccarty force-pushed the ajtm-04212025-dedup-patches branch from c40a07e to 5521508 Compare April 29, 2025 19:48
@ajtmccarty ajtmccarty merged commit c5d0949 into stable Apr 30, 2025
35 checks passed
@ajtmccarty ajtmccarty deleted the ajtm-04212025-dedup-patches branch April 30, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants