Refactor computed attribute update_computed_attribute_value_jinja2 #6348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #6348 will not alter performanceComparing Summary
|
dgarros
reviewed
Apr 23, 2025
dgarros
approved these changes
Apr 24, 2025
ogenstad
force-pushed
the
pog-refactor-computed-attribute-filter-query
branch
from
e8c56ad to
9fb0e74
Compare
dgarros
approved these changes
Apr 25, 2025
dgarros
reviewed
Apr 25, 2025
changelog/6351.fixed.md
Outdated
| @@ -0,0 +1 @@ | |||
| Replace client.filter call in Jinja2 based computed attributes. Depending on schema and data this change will be yield a significant performance improvement for the computed attributes. | |||
There was a problem hiding this comment.
I think the changelog should focus first on the user benefit more than the implementation, here it could be
Improve performance of computed attributes when updating a large number of objects at once. Replaced client.filter call in Jinja2 based computed attributes.
There was a problem hiding this comment.
Good call, I've updated the changelog. Will merge when the CI completes.
Use custom GraphQL query instead of using a query defined by the SDK
ogenstad
force-pushed
the
pog-refactor-computed-attribute-filter-query
branch
from
9fb0e74 to
658af4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use custom GraphQL query instead of using a query defined by the SDK
Fixes #6351.