Mutating a backend node with extra attrs logs instead of raising #6350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #6350 will not alter performanceComparing Summary
|
LucasG0
force-pushed
the
lgu-log-on-extra-attr
branch
2 times, most recently
from
8a227ee to
7274f67
Compare
LucasG0
force-pushed
the
lgu-log-on-extra-attr
branch
from
7274f67 to
a564eb0
Compare
ogenstad
approved these changes
Apr 25, 2025
| assert "not a valid input" in str(exc.value) | ||
| assert node.name.value == "low" | ||
| assert node.level.value == 4 | ||
| assert not hasattr(node, "notvalid") |
There was a problem hiding this comment.
It would be nice if the test captured the log entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6349