fix(backend): make uniqueness constraint query use indexes #6392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
Use more granular subqueries depending on the parameters so that the planner can find the best index. Otherwise the planner might use the attribute name index instead of the attribute value index when the latter is available. Signed-off-by: Fatih Acar <[email protected]>
fatih-acar
force-pushed
the
fac-fix-uniqueness-constr-index
branch
from
1d787d1 to
5d962a0
Compare
CodSpeed Performance ReportMerging #6392 will not alter performanceComparing Summary
|
|
Please do not merge yet, I need to run benchmarks with the feature flag disabled to confirm there's no regression. |
ajtmccarty
approved these changes
May 1, 2025
This should prevent potential performance regression when the value index is not present (feature flag disabled). Signed-off-by: Fatih Acar <[email protected]>
ajtmccarty
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more granular subqueries depending on the parameters so that the planner can find the best index.
Otherwise the planner might use the attribute name index instead of the attribute value index when the latter is available.