Skip to content

fix(backend): IPAM read/list performance improvements #6416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

fatih-acar
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label May 6, 2025
@fatih-acar fatih-acar force-pushed the fac-improve-hierarchy-query-default-branch branch from e110d91 to c4aa5da Compare May 6, 2025 13:02
@fatih-acar fatih-acar force-pushed the fac-improve-hierarchy-query-default-branch branch from c4aa5da to 3a24be8 Compare May 6, 2025 13:13
Copy link

codspeed-hq bot commented May 6, 2025

CodSpeed Performance Report

Merging #6416 will not alter performance

Comparing fac-improve-hierarchy-query-default-branch (e4db1aa) with stable (e1bce6b)

Summary

✅ 10 untouched benchmarks

Without this change, the planner will use the peer node index (either
node uuid or attribute value index) as the starting point of the query.
Thus in the case of IPAM, when we have a single namespace with thousands
of addresses/prefixes, it will start the query from the namespace and
traverse all the addresses/prefixes inside that same namespace (thus
retraversing all addresses for each address...).

Unfortunately, it looks like there's no support to "ignore" an index, so
a little trick here is to filter the actual starting node using its own
uuid to force the planner to use that node as the starting point.

Signed-off-by: Fatih Acar <[email protected]>
@fatih-acar fatih-acar force-pushed the fac-improve-hierarchy-query-default-branch branch from 3a24be8 to e4db1aa Compare May 6, 2025 13:44
Copy link
Contributor

@ajtmccarty ajtmccarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fatih-acar fatih-acar marked this pull request as ready for review May 7, 2025 13:45
@fatih-acar fatih-acar requested a review from a team as a code owner May 7, 2025 13:45
@fatih-acar fatih-acar merged commit 197f7ed into stable May 7, 2025
35 checks passed
@fatih-acar fatih-acar deleted the fac-improve-hierarchy-query-default-branch branch May 7, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants