Stable to develop #6443
Merged
Stable to develop #6443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fatih Acar <[email protected]>
Signed-off-by: Fatih Acar <[email protected]>
…y-dispatcher ci: add INFRAHUB_CUSTOMER2_REPOSITORY to repository-dispatcher
* fix textarea display * fix display value component * add fragment * ignore textarea spelling in fragment * update fragment
* logic for deleting nodes removed from a diff * use filter model instead of dict, use NodeIdentifier in filters * update drop nodes query to remove diff nodes completely
* logic for deleting nodes removed from a diff * use filter model instead of dict, use NodeIdentifier in filters * update drop nodes query to remove diff nodes completely * add node kind to node field specifiers * add a hash method for some reason * remove extraneous, commented-out line * replace kind and uuid on DiffNode classes with NodeIdentifier that includes database-level labels * small cleanup tasks * use IDs list in diff path queries * save changes to test for diff calculation with migrated kind for later * add a docstring for a class * formatting
…nd details views (#6405) * update date format * add fragment * add util function * show year only for dates before the current year * update fragment * update date format
This might trigger the creation of a lot of templates from a schema perspective but this is required to fix the inheritance for the GraphQL schema.
…anch Signed-off-by: Fatih Acar <[email protected]>
Without this change, the planner will use the peer node index (either node uuid or attribute value index) as the starting point of the query. Thus in the case of IPAM, when we have a single namespace with thousands of addresses/prefixes, it will start the query from the namespace and traverse all the addresses/prefixes inside that same namespace (thus retraversing all addresses for each address...). Unfortunately, it looks like there's no support to "ignore" an index, so a little trick here is to filter the actual starting node using its own uuid to force the planner to use that node as the starting point. Signed-off-by: Fatih Acar <[email protected]>
* fix bug in rel create for migrated kind nodes * handle agnostic rels correctly
change wording
Break apart ignored mypy rules to individual error codes
json.dumps serializes to a format that is not equivalent to the JSON.Stringify (JS) format. Also do not raise Exception if the payload was not successfully sent. Signed-off-by: Fatih Acar <[email protected]>
Signed-off-by: Fatih Acar <[email protected]>
…y-dispatcher ci: add INFRAHUB_CUSTOMER3_REPOSITORY to repository-dispatcher
* Make sure sync only runs on commit to stable * Add change to the doc * Let me test * Remove test
This is a workaround to allow large Dropdown choices within the Schema. At some point we should convert these attributes to another type than "AttributeValue" in order to add an index to all "AttributeValue" nodes.
…s-IFC-1483 Add 'List' kinds to LARGE_ATTRIBUTE_TYPES
fix webhook signature calculation
… row actions (#6373) * enable dissocate action only for optional relationships * add fragment * add count * dissociate if min_count is fine * rename variable and fix edit form * add edit relationship test + use branch * fix dissociate checks * update fragment * update dissociate action * add comment * rename file and update import * update logic * fix dissociate check * update check * add mock data * add test * update comment * rename files, update types * add generic use case * remove old mock data * use utils function * refactor dissociate check * Fix ts errors + improved code logic with early return * added tests * more tests * made usage simplier and added more tests * lint * cleaning --------- Co-authored-by: bilalabbad <[email protected]>
github-actions
bot
added
type/documentation
ajtmccarty
commented
May 12, 2025
| return await object_template.get_peer(db=db) if object_template is not None else None | ||
| return ( | ||
| await object_template.get_peer(db=db, peer_type=CoreObjectTemplate) if object_template is not None else None | ||
| ) |
There was a problem hiding this comment.
had to make this change for pylint on develop
CodSpeed Performance ReportMerging #6443 will not alter performanceComparing Summary
|
ogenstad
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.