Fix conftestpy #4
Conversation
…naconda environment so I marked them for future work
|
I forgot to mention that all tests still pass except the ones marked with xfail. It looks like the ones marked with xfail are referencing fixtures that do not exist yet. |
There was a problem hiding this comment.
Instead of a pipfile, I was going to include a requirements.txt. It's in my current branch. It seems like pipfile and pipfile.lock is the newer way to do this. It seems a lot like yarn in the nodejs world.
There was a problem hiding this comment.
Pipenv was a workflow I gravitated towards and just got hooked. My favorite part is the pipenv graph command. There is a way to kick out a requirements file from the pipenv if you prefer that.
| @@ -11,6 +14,7 @@ def test_kwargs_are_set_as_attributes(): | |||
| assert combo.transaction_id == tx_id | |||
| assert combo.user_defined == user_defined | |||
|
|
|||
| @pytest.mark.xfail(raises=NameError) | |||
There was a problem hiding this comment.
These tests were not updated after the refactor of the option object, so this is fine.
There was a problem hiding this comment.
This file is deleted in my branch. It was just a file to make sure my test runner configuraion was set up properly in the IDE.
This PR will remap all the fixtures previously referenced in the option test helper module into a conftest.py implementation. No tests were changed except a handful that had to be refactored to not include fixtures inside the parametrized fixtures.
I branched from the initial PR I made so this PR will merge smoothly if the previous PR is approved.