Skip to content

Remove dependency on async-trait. #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

Remove dependency on async-trait. #1922

merged 1 commit into from
Jul 10, 2025

Conversation

davidv1992
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.30%. Comparing base (30d6185) to head (6c5fa9c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ntpd/src/daemon/spawn/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1922      +/-   ##
==========================================
- Coverage   83.44%   83.30%   -0.15%     
==========================================
  Files          71       71              
  Lines       19237    19276      +39     
==========================================
+ Hits        16053    16058       +5     
- Misses       3184     3218      +34     
Flag Coverage Δ
fuzz-cookie_parsing_sound 0.45% <ø> (ø)
fuzz-duration_from_float 0.29% <ø> (ø)
fuzz-encrypted_client_parsing 7.18% <ø> (-0.98%) ⬇️
fuzz-encrypted_server_parsing 10.82% <ø> (-0.07%) ⬇️
fuzz-ipfilter 2.75% <ø> (ø)
fuzz-key_exchange_request_parsing 2.30% <ø> (-1.23%) ⬇️
fuzz-key_exchange_response_parsing 2.63% <ø> (-1.54%) ⬇️
fuzz-packet_keyset 5.40% <ø> (-0.83%) ⬇️
fuzz-packet_parsing_sound 6.23% <ø> (-2.54%) ⬇️
fuzz-record_encode_decode 3.19% <ø> (-0.04%) ⬇️
test-aarch64-apple-darwin 83.02% <0.00%> (-0.08%) ⬇️
test-x86_64-unknown-linux-gnu 82.93% <0.00%> (-0.08%) ⬇️
test-x86_64-unknown-linux-musl 82.93% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rnijveld
rnijveld previously approved these changes Jul 7, 2025
@rnijveld rnijveld added this pull request to the merge queue Jul 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 7, 2025
@rnijveld rnijveld added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit a9985fd Jul 10, 2025
28 checks passed
@rnijveld rnijveld deleted the eliminate-async-trait branch July 10, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants