Fixes a tiny bug when calling expire_page in production environment #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I applied your patch to spree fork - spree-contrib@a70594f |
peterberkenbosch
force-pushed
the
master
branch
from
fdaf7e4 to
78b4248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When RAILS_ENV=production, calling expire_page (i.e. when updating a static page), results in a 404 (by calling a non-existant route)...
This is due to the fact that the route passed to expire_page has a controller specified without a trailing slash.
This results in the actual controller being called is 'admin/static_content' while it is evident (just by looking at the folder structure), that the 'static_content' controller is meant to be outside the admin namespace...
Hope you'll pull it :)
Keep up the good work.
Matteo