h3: Remove streams on StreamClosed #309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was playing around with HTTP3 in Hypercorn and noticed significant memory leaks during long-lived connections.
After some investigation, I discovered that Hypercorn doesn't properly remove finished streams from the
H3Protocol.streamsdict. This leads to unbounded memory growth over time.This PR fixes the issue. Interestingly, the solution is just one line: the
StreamClosedevent was already being handled in the H3 protocol, but the handler didn't actually remove the stream.However, there is another memory leak, this time in the aioquic library itself, which I addresses in this PR - aiortc/aioquic#590. Once (and if) that fix is merged, Hypercorn should bump its aioquic dependency to ensure that both memory leaks are fully resolved.