Skip to content

Update Unix requirements section #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jul 24, 2024

C99 is required as of php/php-src@b51a99a.

There is likely more to update on that page. If anybody happens to know which versions exactly, please tell me. Otherwise I'll check that out.

PS: The info about bison and r2c versions is apparently up-to-date.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have updated the re2c and bison requirements a few times

@cmb69
Copy link
Member Author

cmb69 commented Jul 26, 2024

I was wondering about autoconf, automake and libtool requirements, but couldn't find any version in the sources so far. Not even sure if these are needed; I think at least autoconf is not necessary when building a proper release.

And we should note that re2c and bison are only required to rebuilt the parsers, what is usually not what users want to do. Maybe remove that part altogether and link to some developer docs (maybe just https://github.com/php/php-src?tab=readme-ov-file#building-php-source-code).

I'll have a closer look at this as soon as possible.

@cmb69
Copy link
Member Author

cmb69 commented Jul 29, 2024

I was wondering about autoconf, automake and libtool requirements, but couldn't find any version in the sources so far. Not even sure if these are needed; I think at least autoconf is not necessary when building a proper release.

@petk, do you happen to know about autoconf, automake and libtool version requirements, or where they can be looked up the source code?

@petk
Copy link
Member

petk commented Jul 29, 2024

I was wondering about autoconf, automake and libtool requirements, but couldn't find any version in the sources so far. Not even sure if these are needed; I think at least autoconf is not necessary when building a proper release.

@petk, do you happen to know about autoconf, automake and libtool version requirements, or where they can be looked up the source code?

Autoconf, re2c and Bison were already rechecked and updated via #3346. They are ok. Minimum versions are defined in the configure.ac. And that Automake and Libtool should be removed as they are not required. But I'll re-check why are they even listed there. The bundled Libtool unfortunately couldn't be updated to the latest version for PHP-8.4 yet (php/php-src#13476). Will be done in the next version.

@petk
Copy link
Member

petk commented Jul 29, 2024

The Libtool and Automake can be removed from this page. Automake was once needed in PHP and some parts needed the aclocal tool which is part of the Automake package. The Libtool was also used a bit inconsistently and there were glitches with versions and the bundled libtool (probably) so therefore it was needed.

https://www.php.net/git.php#buildconf_fail

About updating this bundled Libtool, I would keep the bundled way only. Because there is also an option to use the system Libtool (latest version) and some PHP installations do that already. But it is much easier to have a shorter list of requirements in the docs.

Also this php.net/git.php page can be probably updated at the bottom (we've left this out back then a bit). But I'll still keep these historical notes on my own somewhere to understand the changes across the versions. https://github.com/petk/php-build-system/blob/master/docs/evolution.md :D

@cmb69 cmb69 closed this Sep 21, 2024
@cmb69 cmb69 deleted the cmb/unix-requirements branch September 21, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants