Skip to content

ext/date: various optimizations of _php_gettimeofday #18560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ext/date: various optimizations of _php_gettimeofday #18560

wants to merge 1 commit into from
+7 −15

Conversation

jorgsowa
Copy link
Contributor

Pre-allocated size of array for _php_gettimeofday and improved typing.

@jorgsowa jorgsowa requested review from bukka and derickr as code owners May 14, 2025 20:49
@jorgsowa jorgsowa changed the title ext/date: various optimizations ext/date: various optimizations of _php_gettimeofday May 14, 2025
devnexen
devnexen approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes themselves are correct, optimisation"s" is only about the output though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@derickr derickr Awaiting requested review from derickr derickr is a code owner

Assignees
No one assigned
Labels
Extension: date Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgsowa @devnexen