Amrnav 4933 add exact mode #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplapp
reviewed
Jun 19, 2023
| // TODO(anyone): find the best function, e.g convex power functions | ||
| scale = cos(alpha_delta); | ||
| else { | ||
| scale = (alpha_delta < M_PI / 6) ? 1.0 : 0.0; |
There was a problem hiding this comment.
would be nice to make this threshold a parameter to experiment with
added 2 commits
June 20, 2023 09:42
|
@jplapp implementation as a parameter is done. Regarding the service to toggle between exact_mode, I just realized that a much cleaner way would be to use the |
jplapp
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.