Use system time for joint_state_broadcaster #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it should be part of the release, it's important for rosbags. |
|
Maybe a good opportunity to out https://lvserv01.logivations.com/browse/AMRFM-1527 back into our list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the gazebo ros2 control that we use, gazebo time is used with no option to use system time. The controllers, namely joint_state_broadcaster will use the same time as the controller manager.
While it does make sense to use the sim time, all our system still uses system time for gazebo simulation. This PR is to force joint_state_broadcaster to use system time.
We should revert this once our other components use sim time