Apply-speed-limit-late #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplapp
approved these changes
Jul 11, 2022
|
I reverted this because it broke master. I will create another PR later. I tested it as much as I could but nothing beats some rebuild and system tests, and these don't run here. This code is tested only when this is merged and by chance there is a built without cache on deepcv, which is way too late We added tests to nav2 but we should also run the system tests in this repo and perhaps other repos too (e.g TEB). As far as I know, the effort to add tests to each repo is big, should we look into simplifying that? @jplapp @MaxZubrytskyi |
|
Also changes here should create a new image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.