Fix wrong topics in metadata requests #73
+58
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Jul 9, 2025
| // For some unknown reason this is necessary, otherwise the test hangs | ||
| // I guess the previous test had the same issue | ||
| // TODO: Investigate why this is necessary | ||
| await new Promise(resolve => setTimeout(resolve, 1000)) |
There was a problem hiding this comment.
I already had a short look at it, but it does not seem easy to find out. I can investigate, but for now, I would keep the investigation independent of this PR if possible.
|
There is one more fix for metadata requests. More on that in the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consumeis failing in the following workflow:The issue is that the consumer still holds a reference to the deleted topic, and metadata requests in the
#fetchmethod fail as metadata for this topic is not available.This PR solves this issue by untracking all topics before retracking the target topics inside the function
#performConsumein theConsumerclass.Edit: This change also disentangles metadata requests with different topics. Previously, metadata requests were deduplicated independently on the topics that were requested, potentially leading to wrong results for subsequent metadata requests. Deduplication is now done based on requested topics.