Moving to python api #245
Merged
Moving to python api #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quiver function plots velocity vectors and Streamline function plots streamlines with directional arrows
clean up
draft of tests
Quiver: can plot 1 arrow
-remove numpy dependency -change to class -additional pep8 edits
@chriddyp @theengineear @etpinard @aneda Could use some feedback: I changed this quite a bit to remove the numpy dependency and make Quiver a class.
not sure if this is the correct way of testing PlotlyErrors
added flatten function added doc for each function -still unsure about decorators? removed decorators but still using super()
Adding Streamline class - Streamline class still uses bumpy dependency - this calculation can be slow with numpy, depending on the range and density. Added core tests for Quiver and Streamline
Create TraceFactory class with methods: create_quiver and create_streamline
update tests for quiver/streamline with TraceFactory
updated re: comment 222 @theengineear is this what you had in mind for TraceFactory? cc @chriddyp @aneda @etpinard
Changing ‘stream’ to ‘streamline’ to avoid user confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.