fix logs polling bug #2298
Merged
fix logs polling bug #2298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsladerman
added
bug-fix
michaeljguarino
approved these changes
May 28, 2025
maciaszczykm
approved these changes
May 28, 2025
michaeljguarino
deleted the
jake/prod-3594-log-view-still-polls-during-scrolls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's not exactly clear what triggers this bug, but it seems like it likely stems from a race condition when "live" is rapidly toggled while the search query is changing (this is expected behavior because changing query filters in most cases will return the scroll to the top, and then the user might immediately scroll down, but "stopPolling" might not necessarily get triggered)
this change simplifies the logic a bit and makes it more declarative
also bumps apollo client minor vsn