[PGPRO-7038] bgworker for aqo_cleanup #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danolivo
requested changes
Sep 19, 2022
danolivo
force-pushed
the
stable13
branch
2 times, most recently
from
dc79224 to
4688cf6
Compare
Alena0704
force-pushed
the
stable13
branch
3 times, most recently
from
bf3a32d to
a8d85d5
Compare
danolivo
reviewed
Oct 4, 2022
| status = GetBackgroundWorkerPid(aqo_state->bgw_handle, &pid); | ||
| } | ||
| } | ||
| LWLockRelease(&aqo_state->bgw_lock); |
There was a problem hiding this comment.
Здесь необязательно вводить новый лок. Операция достаточно редкая и короткая, можно воспользоваться aqo_state->lock
| } | ||
| } | ||
| LWLockRelease(&aqo_state->bgw_lock); | ||
| elog(LOG, "status %d", status); |
There was a problem hiding this comment.
Этот код точно не нужен в релизе
|
|
||
| LWLockAcquire(&aqo_state->bgw_lock, LW_EXCLUSIVE); | ||
| if (aqo_state->bgw_handle != NULL) | ||
| { |
There was a problem hiding this comment.
Такой вариант опасен: если ждать окончания очистки, можно подвесить всех бэкендов на данном хуке. Стоит посмотреть в сторону следующей логики:
'Если удаляется объект проверить bgw_handle и получить pid процесса. Если он еще живой, то ничего не делать. Если не запущен, то запустить и выйти из функции. Если pid уже недействующий, поставить bgw_handle = NULL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.