[SHRDM-762] extract info from foreign join #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is an issue here - we use postgres_fdw.h, which is not included in PostgreSQL installation, so out of tree build (USE_PGXS=1) is broken. |
danolivo
reviewed
Oct 13, 2022
expected/aqo_fdw.out
Outdated
| @@ -75,6 +70,19 @@ SELECT x FROM frgn WHERE x < 10; | |||
| JOINS: 0 | |||
| (7 rows) | |||
|
|
|||
| EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, VERBOSE) | |||
There was a problem hiding this comment.
А почему только тривиальный Foreign Scan? Может быть еще проверить на пуше чего-то посложнее ?
There was a problem hiding this comment.
Это просто фикс существующего теста. Там еще есть foreign join по равенству и неравенству. Что добавить? Соединения нескольких таблиц?
There was a problem hiding this comment.
Добавил еще тест, что мы можем корректно оценить количество записей в foreign join.
pyhalov
force-pushed
the
sdm-14-SHRDM-762
branch
from
9f19a09 to
2266cff
Compare
danolivo
force-pushed
the
sdm-14-SHRDM-762
branch
2 times, most recently
from
2bf2ecf to
f4d7a38
Compare
pyhalov
force-pushed
the
sdm-14-SHRDM-762
branch
from
f4d7a38 to
65efa48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.