allow WithNetworkConfig and WithInteractshOptions to be used by NewThreadSafeNucleiEngineCtx

[meme-lord]

Proposed changes

This pull request resolves #5952
It allows the WithInteractshOptions and WithNetworkConfig to be used if engine.init() has not yet been called by checking if interactshOpts or hostErrCache is nil.

Checklist

• Pull request is created against the dev branch
• All checks passed (lint, unit/integration/regression tests etc.) with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Summary by CodeRabbit

• Documentation
  • Added clarifying comments for configuration functions related to thread-safe engine initialization
  • Improved inline documentation to guide developers on correct usage of configuration methods

[coderabbitai]

Walkthrough

The pull request focuses on enhancing the documentation for WithInteractshOptions and WithNetworkConfig functions in the lib/config.go file. The changes clarify the usage of these functions specifically for ThreadSafeNucleiEngine, providing more context about when and how they can be applied during engine initialization. The core logic of the functions remains unchanged, with the primary modification being the addition of explanatory comments.

Changes

File	Change Summary
lib/config.go	Added clarifying comments for WithInteractshOptions and WithNetworkConfig functions regarding their usage with ThreadSafeNucleiEngine

Assessment against linked issues

Objective	Addressed	Explanation
Allow configuration of MaxHostError and Timeout for ThreadSafeNucleiEngine [#5952]	❓	Comments added, but no actual implementation change visible

Possibly related PRs

• fix(sdk): NoHostErrors not set #5783: Changes related to hostErrCache handling in similar configuration functions

Suggested reviewers

• tarunKoyalwar
• dwisiswant0
• ehsandeep

Poem

🐰 A rabbit's config tale unfolds,
With comments clear and wisdom bold,
ThreadSafe Engine, now more bright,
Options dancing with delight,
Configuration's gentle hold! 🔧

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 812a30e and e3c6849.

📒 Files selected for processing (1)

• lib/config.go (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• lib/config.go

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[GeorginaReeder]

Thanks for your contribution @meme-lord ! :)

[github-actions]

This pull request has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs. Please update if you wish to keep it open.

[dogancanbakir]

Thanks for the PR! Apologies for the late review!! You should be able to set during init as:

ne, err := nuclei.NewThreadSafeNucleiEngineCtx(
    context.Background(),
    nuclei.WithInteractshOptions(nuclei.InteractshOpts{
        ...
    }),
)

missing something here?