Skip to content

Removing singletons #6210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from
Draft

Removing singletons #6210

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a87b310
introducing execution id
Mzack9999 May 5, 2025
e44e3a4
wip
Mzack9999 May 6, 2025
5d17531
.
Mzack9999 May 6, 2025
f27b251
adding separate execution context id
Mzack9999 May 7, 2025
752bd3b
Merge branch 'dev' into feat-5239-no-singleton
Mzack9999 May 7, 2025
6692c1d
lint
Mzack9999 May 7, 2025
89020a6
vet
Mzack9999 May 7, 2025
781ca16
Merge branch 'dev' into feat-5239-no-singleton
Mzack9999 May 8, 2025
d5066dd
fixing pg dialers
Mzack9999 May 8, 2025
3b8241c
test ignore
Mzack9999 May 9, 2025
736ee5a
fixing loader FD limit
Mzack9999 May 9, 2025
dfc8ed8
test
Mzack9999 May 9, 2025
2a6c6da
fd fix
Mzack9999 May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fd fix
  • Loading branch information
@Mzack9999
Mzack9999 committed May 9, 2025
commit 2a6c6dab552fa414d80f36468e65cd3f4fda9cc0
9 changes: 6 additions & 3 deletions pkg/catalog/loader/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"os"
"sort"
"strings"
"sync"

"github.com/logrusorgru/aurora"
"github.com/pkg/errors"
Expand All @@ -28,6 +27,7 @@ import (
errorutil "github.com/projectdiscovery/utils/errors"
sliceutil "github.com/projectdiscovery/utils/slice"
stringsutil "github.com/projectdiscovery/utils/strings"
syncutil "github.com/projectdiscovery/utils/sync"
urlutil "github.com/projectdiscovery/utils/url"
"github.com/rs/xid"
)
Expand Down Expand Up @@ -504,7 +504,10 @@ func (store *Store) LoadTemplatesWithTags(templatesList, tags []string) []*templ
}
}

var wgLoadTemplates sync.WaitGroup
wgLoadTemplates, errWg := syncutil.New(syncutil.WithSize(50))
if errWg != nil {
panic("could not create wait group")
}

if store.config.ExecutorOptions.Options.ExecutionId == "" {
store.config.ExecutorOptions.Options.ExecutionId = xid.New().String()
Expand All @@ -516,7 +519,7 @@ func (store *Store) LoadTemplatesWithTags(templatesList, tags []string) []*templ
}

for templatePath := range templatePathMap {
wgLoadTemplates.Add(1)
wgLoadTemplates.Add()
go func(templatePath string) {
defer wgLoadTemplates.Done()

Expand Down
Loading