Fix Dell iDrac mib sed for BSD/MacOS #1183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation appearently breaks on the Mac `sed` implementation I noticed. This still applies the fix, but uses an intermediate temporary file that atomically moved in place after the operation. Signed-off-by: Francis Begyn <[email protected]>
|
The iDRAC-SMIv1.mib is zero bytes after the sed (tested on macos/BSD and linux/GNU) 👎 |
Signed-off-by: SuperQ <[email protected]>
SuperQ
force-pushed
the
superq/fix_idrac_awk
branch
from
008be1c to
deaaa8f
Compare
|
Fixed sed syntax. |
|
Closing in favor of #1185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation appearently breaks on the Mac
sedimplementation I noticed.This still applies the fix, but uses an intermediate temporary file that atomically moved
in place after the operation.