Skip to content

chore: clean up and sort golangci-lint configuration #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: clean up and sort golangci-lint configuration #1421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 13 additions & 24 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,12 @@
version: "2"
linters:
disable:
- unused
enable:
- misspell
- revive
- sloglint
disable:
- unused
settings:
errcheck:
exclude-functions:
- (net/http.ResponseWriter).Write
revive:
rules:
- name: unused-parameter
severity: warning
disabled: true
exclusions:
generated: lax
generated: strict
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since strict is the default already, do we need it explicitly?

presets:
- comments
- common-false-positives
Expand All @@ -27,14 +17,13 @@ linters:
- errcheck
- govet
path: _test.go
paths:
- third_party$
- builtin$
- examples$
formatters:
exclusions:
generated: lax
paths:
- third_party$
- builtin$
- examples$
settings:
errcheck:
exclude-functions:
- (net/http.ResponseWriter).Write
revive:
rules:
- name: unused-parameter
severity: warning
disabled: true
version: "2"