Remove remains of deriving and decypher large regexp
#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`deriving` isn't a thing in PureScript. There's `derive` keyword, but it has a bit different structure (specifically, it is a top-level keyword). Related discussion: https://discourse.purescript.org/t/solved-is-deriving-keyword-a-thing-in-purescript/4787
The 204 characters line full of backslashes and parentheses isn't the most readable code. Replace it with `rx` expression instead, which makes author's intentions much clearer. As can be checked by evaluation, the resulting regexp is exactly the same, barring the "'_" part was moved to the left of [:alnum:].
Hi-Angel
force-pushed
the
rm-deriving
branch
from
8ad0d2a to
2b96f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit removes the remains of
derivingkeyword.derivingisn't a thing in PureScript. Also, related discussion on PureScript Discourse.Second commit is just a stylistic change: the large regexp in
purescript-indentation-peek-tokenwas converted torxmacro. It bears no functional change and the regexp generated byrxis exactly the same (barring that'_part was to the right of[:alnum:]and now it's to the left). Hopefully, the resulting code is easier to read and maintain.