Skip to content

font-lock: unduplicate operator-faces and test them #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2025

Conversation

Hi-Angel
Copy link
Member

@Hi-Angel Hi-Angel commented May 2, 2025

No description provided.

@Hi-Angel Hi-Angel changed the title font-lock: unduplicate operator-faces and add tests font-lock: unduplicate operator-faces and test them May 2, 2025
It was used in the past for the purposes of some conditional at the
end of the function, but the conditional was removed, so now
`keywords` does nothing useful. So remove it as well.
@Hi-Angel Hi-Angel force-pushed the font-lock-operator-fixes branch from aad12b0 to d150f6d Compare May 4, 2025 08:39
@Hi-Angel
Copy link
Member Author

Hi-Angel commented May 4, 2025

So, interestingly, I just realized that purescript-operator-face is defined to be font-lock-variable-name-face, which isn't good. Emacs has font-lock-operator-face, but the information on whether it's supported in 25.1 is conflicting. The defface font-lock-operator-face claims it's available since 29.1, but then this documentation makes no such note and I just tried running tests with the older emacsen and compilation stage passes just fine (e.g. in 25.1 testing phase does fail, because obviously face has changed — but compilation passes).

Will have to look at that…

@Hi-Angel Hi-Angel merged commit 6eb17d9 into purescript-emacs:master May 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant