purescript-font-lock.el: highlight docstrings unconditionally #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable was introduced to avoid highlighting docstrings for Emacs versions where `font-lock-doc-face` didn't exist, that is prior to 21. It's a variable from very old times and nowadays we support Emacs 25.1+ which has font-lock-doc-face. So remove the variable and the condition. For the safe case I did search over Github, and the variable isn't mentioned anywhere except the literal copies of the font-lock.el file.
Hi-Angel
force-pushed
the
rm-docstring-var
branch
from
d9b934b to
861e13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable was introduced to avoid highlighting docstrings for Emacs versions where
font-lock-doc-facedidn't exist, that is prior to 21.It's a variable from very old times and nowadays we support Emacs 25.1+ which has font-lock-doc-face. So remove the variable and the condition.
For the safe case I did search over Github, and the variable isn't mentioned anywhere except the literal copies of the font-lock.el file.